From: Laurent Wandrebeck <l.wandrebeck@free.fr>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [patch 1/1] telephony ixc missing return check for request_region()
Date: Fri, 17 Mar 2006 14:15:17 +0100 [thread overview]
Message-ID: <200603171415.18120.l.wandrebeck@free.fr> (raw)
Hi,
in drivers/telephony/ixj.c, request_region() is called without checking the return
value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.
Signed-off-by: Laurent Wandrebeck <l.wandrebeck@free.fr>
--- linux-2.6.16-rc6/drivers/telephony/ixj.c.ori 2006-03-11 23:12:55.000000000 +0100
+++ linux-2.6.16-rc6/drivers/telephony/ixj.c 2006-03-17 14:10:32.000000000 +0100
@@ -6802,7 +6802,10 @@ static int ixj_selfprobe(IXJ *j)
}
} else if (j->dsp.low == 0x22) {
j->cardtype = QTI_PHONEJACK_PCI;
- request_region(j->XILINXbase, 4, "ixj control");
+ if (!request_region(j->XILINXbase, 4, "ixj control")) {
+ printk(KERN_INFO "ixj: can't get I/O address 0x%x\n", j->XILINXbase);
+ return -1;
+ }
j->pld_slicw.pcib.e1 = 1;
outb_p(j->pld_slicw.byte, j->XILINXbase);
} else
reply other threads:[~2006-03-17 13:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603171415.18120.l.wandrebeck@free.fr \
--to=l.wandrebeck@free.fr \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®