From: Laurent Wandrebeck <l.wandrebeck@free.fr>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, jejb@steeleye.com
Subject: [patch 1/1] scsi mca_53c9x missing return check for request_region()
Date: Fri, 17 Mar 2006 14:33:05 +0100 [thread overview]
Message-ID: <200603171433.06029.l.wandrebeck@free.fr> (raw)
Hi,
in drivers/scsi/mca_53c9x.c, request_region() is called without checking the return
value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.
Signed-off-by: Laurent Wandrebeck <l.wandrebeck@free.fr>
--- linux-2.6.16-rc6/drivers/scsi/mca_53c9x.c.ori 2006-03-11 23:12:55.000000000 +0100
+++ linux-2.6.16-rc6/drivers/scsi/mca_53c9x.c 2006-03-17 14:20:44.000000000 +0100
@@ -195,7 +195,15 @@ static int mca_esp_detect(struct scsi_ho
return 0;
}
- request_region(tmp_io_addr, 32, "NCR 53c9x SCSI");
+ if (!request_region(tmp_io_addr, 32, "NCR 53c9x SCSI")) {
+ printk("Unable to request region %d.\n",
+ tmp_io_addr);
+ free_dma(esp->dma);
+ free_irq(esp->irq, esp_intr);
+ esp_deallocate(esp);
+ scsi_unregister(esp->ehost);
+ return 0;
+ }
/*
* 86C01 handles DMA, IO mode, from address
reply other threads:[~2006-03-17 13:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603171433.06029.l.wandrebeck@free.fr \
--to=l.wandrebeck@free.fr \
--cc=akpm@osdl.org \
--cc=jejb@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®