From: Laurent Wandrebeck <l.wandrebeck@free.fr>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: missing return value check for request_region() in in2000.c
Date: Fri, 17 Mar 2006 15:11:10 +0100 [thread overview]
Message-ID: <200603171511.10791.l.wandrebeck@free.fr> (raw)
Hi,
in drivers/scsi/in2000.c, request_region() is called without checking the return
value. Here is a patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.
Signed-off-by: Laurent Wandrebeck <l.wandrebeck@free.fr>
--- linux-2.6.16-rc6/drivers/scsi/in2000.c.ori 2006-03-17 14:42:20.000000000 +0100
+++ linux-2.6.16-rc6/drivers/scsi/in2000.c 2006-03-17 14:50:14.000000000 +0100
@@ -2010,7 +2010,12 @@ static int __init in2000_detect(struct s
}
instance->irq = x;
instance->n_io_port = 13;
- request_region(base, 13, "in2000"); /* lock in this IO space for our use */
+ if (!request_region(base, 13, "in2000")) { /* lock in this IO space for our use */
+ printk(KERN_ERR "in2000: unable to reserve region 0x%x\n", base);
+ free_irq(instance->irq, instance);
+ detect_count--;
+ continue;
+ }
for (x = 0; x < 8; x++) {
hostdata->busy[x] = 0;
reply other threads:[~2006-03-17 14:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603171511.10791.l.wandrebeck@free.fr \
--to=l.wandrebeck@free.fr \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®