From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: rjw@sisk.pl, pavel@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: -mm: PM=y, VT=n doesn't compile
Date: Fri, 17 Mar 2006 17:50:19 -0800 [thread overview]
Message-ID: <20060317175019.7c000847.akpm@osdl.org> (raw)
In-Reply-To: <20060317171814.GO3914@stusta.de>
Adrian Bunk <bunk@stusta.de> wrote:
>
> swsusp-pm-refuse-to-suspend-devices-if-wrong-console-is-active.patch
> causes the following compile error with CONFIG_PM=y, CONFIG_VT=n:
>
> <-- snip -->
>
> ...
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `device_suspend': undefined reference to `fg_console'
> drivers/built-in.o: In function `device_suspend': undefined reference to `vc_cons'
> make: *** [.tmp_vmlinux1] Error 1
Right, thanks. I'll drop that patch.
Guys, please don't go poking around in the vt subsystems's internal data
structures from within power management code.
Write a nice little helper function, put that in vt.c, give it a static
inline `return 0' stub in the header file, then call that.
That's Kernel Programming 101, no?
next prev parent reply other threads:[~2006-03-18 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 17:18 Adrian Bunk
2006-03-18 1:50 ` Andrew Morton [this message]
2006-03-18 19:34 ` Rafael J. Wysocki
2006-03-18 16:04 ` Rafael J. Wysocki
2006-03-18 19:48 ` Andrew Morton
2006-03-18 19:58 ` Rafael J. Wysocki
2006-03-18 20:28 ` Rafael J. Wysocki
2006-03-19 18:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317175019.7c000847.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome