From: Andrew Morton <akpm@osdl.org>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@muc.de>
Subject: Re: [patch] Mark cyc2ns_scale readmostly
Date: Fri, 17 Mar 2006 21:36:04 -0800 [thread overview]
Message-ID: <20060317213604.3a97aaeb.akpm@osdl.org> (raw)
In-Reply-To: <20060317210858.GA3666@localhost.localdomain>
Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
>
> This variable is rarely written to. Mark the variable accordingly
>
I dropped all John's timekeeping patches today - he's redoing everything.
So I've reworked this against mainline.
x86 actually has two cyc2ns_scale's.
arch/i386/kernel/timers/timer_hpet.c | 2 +-
arch/i386/kernel/timers/timer_tsc.c | 2 +-
arch/x86_64/kernel/time.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff -puN arch/i386/kernel/timers/timer_hpet.c~mark-cyc2ns_scale-readmostly arch/i386/kernel/timers/timer_hpet.c
--- devel/arch/i386/kernel/timers/timer_hpet.c~mark-cyc2ns_scale-readmostly 2006-03-17 21:34:19.000000000 -0800
+++ devel-akpm/arch/i386/kernel/timers/timer_hpet.c 2006-03-17 21:34:19.000000000 -0800
@@ -46,7 +46,7 @@ static seqlock_t monotonic_lock = SEQLOC
*
* -johnstul@us.ibm.com "math is hard, lets go shopping!"
*/
-static unsigned long cyc2ns_scale;
+static unsigned long cyc2ns_scale __read_mostly;
#define CYC2NS_SCALE_FACTOR 10 /* 2^10, carefully chosen */
static inline void set_cyc2ns_scale(unsigned long cpu_khz)
diff -puN arch/i386/kernel/timers/timer_tsc.c~mark-cyc2ns_scale-readmostly arch/i386/kernel/timers/timer_tsc.c
--- devel/arch/i386/kernel/timers/timer_tsc.c~mark-cyc2ns_scale-readmostly 2006-03-17 21:34:19.000000000 -0800
+++ devel-akpm/arch/i386/kernel/timers/timer_tsc.c 2006-03-17 21:34:19.000000000 -0800
@@ -74,7 +74,7 @@ late_initcall(start_lost_tick_compensati
*
* -johnstul@us.ibm.com "math is hard, lets go shopping!"
*/
-static unsigned long cyc2ns_scale;
+static unsigned long cyc2ns_scale __read_mostly;
#define CYC2NS_SCALE_FACTOR 10 /* 2^10, carefully chosen */
static inline void set_cyc2ns_scale(unsigned long cpu_khz)
diff -puN arch/x86_64/kernel/time.c~mark-cyc2ns_scale-readmostly arch/x86_64/kernel/time.c
--- devel/arch/x86_64/kernel/time.c~mark-cyc2ns_scale-readmostly 2006-03-17 21:34:19.000000000 -0800
+++ devel-akpm/arch/x86_64/kernel/time.c 2006-03-17 21:34:19.000000000 -0800
@@ -477,7 +477,7 @@ static irqreturn_t timer_interrupt(int i
return IRQ_HANDLED;
}
-static unsigned int cyc2ns_scale;
+static unsigned int cyc2ns_scale __read_mostly;
#define CYC2NS_SCALE_FACTOR 10 /* 2^10, carefully chosen */
static inline void set_cyc2ns_scale(unsigned long cpu_khz)
_
prev parent reply other threads:[~2006-03-18 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 21:08 Ravikiran G Thirumalai
2006-03-18 5:36 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317213604.3a97aaeb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®