From: Andrew Morton <akpm@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: kernel-stuff@comcast.net, linux-kernel@vger.kernel.org,
alex-kernel@digriz.org.uk, jun.nakajima@intel.com,
davej@redhat.com
Subject: Re: OOPS: 2.6.16-rc6 cpufreq_conservative
Date: Sat, 18 Mar 2006 16:53:02 -0800 [thread overview]
Message-ID: <20060318165302.62851448.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0603181321310.3826@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> wrote:
>
> Gaah. Looking at the assembly code to try to figure out where the oops
> happened, one thing is clear: "for_each_cpu_mask()" generates some truly
> horrible code. C code that looks simple ends up being tons of complex
> assembly language due to inline functions etc.
>
> We've made it way too easy for people to write code that just absolutely
> _sucks_.
Yes, uninlining merely first_cpu() shrinks my usual vmlinux by 2.5k. I'll
fix it up.
Meanwhile, I suppose we need to check that pointer for NULL as Parag
suggests. I might stick a once-off WARN_ON() in there so someone gets in
and works out why we keep on having to graft mysterious null-pointer
avoidances into cpufreq.
next prev parent reply other threads:[~2006-03-19 0:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-18 20:25 Parag Warudkar
2006-03-18 21:40 ` Linus Torvalds
2006-03-18 22:09 ` Parag Warudkar
2006-03-18 23:12 ` Linus Torvalds
2006-03-18 22:26 ` Parag Warudkar
2006-03-19 0:53 ` Andrew Morton [this message]
2006-03-19 2:38 ` Linus Torvalds
2006-03-19 5:08 ` Paul Jackson
2006-03-19 17:43 ` Linus Torvalds
2006-03-19 18:46 ` Linus Torvalds
2006-03-19 19:02 ` Linus Torvalds
2006-03-19 19:33 ` Linus Torvalds
2006-03-19 19:40 ` Al Viro
2006-03-19 20:01 ` Linus Torvalds
2006-03-19 20:31 ` Linus Torvalds
2006-03-19 20:47 ` Andrew Morton
2006-03-19 22:18 ` Linus Torvalds
2006-03-19 22:35 ` Andrew Morton
2006-03-19 22:55 ` Linus Torvalds
2006-03-19 22:46 ` Linus Torvalds
2006-03-19 23:04 ` Andrew Morton
2006-03-19 20:57 ` Parag Warudkar
2006-03-20 6:12 ` Willy Tarreau
2006-03-20 6:26 ` Linus Torvalds
2006-03-20 7:18 ` Willy Tarreau
2006-03-21 6:32 ` Willy Tarreau
2006-03-20 8:22 ` Peter T. Breuer
2006-03-19 6:34 ` Parag Warudkar
2006-03-19 12:00 ` Alexander Clouter
2006-03-19 14:06 ` Parag Warudkar
2006-03-19 17:34 ` Alexander Clouter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060318165302.62851448.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alex-kernel@digriz.org.uk \
--cc=davej@redhat.com \
--cc=jun.nakajima@intel.com \
--cc=kernel-stuff@comcast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®