From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Takashi Iwai <tiwai@suse.de>, Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH] fix resource leak in usbmixer
Date: Sat, 18 Mar 2006 23:27:42 +0100 [thread overview]
Message-ID: <200603182327.42389.jesper.juhl@gmail.com> (raw)
We may leak 'namelist' in sound/usb/usbmixer.c::parse_audio_selector_unit()
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
sound/usb/usbmixer.c | 1 +
1 files changed, 1 insertion(+)
--- linux-2.6.16-rc6-orig/sound/usb/usbmixer.c 2006-03-12 14:19:19.000000000 +0100
+++ linux-2.6.16-rc6/sound/usb/usbmixer.c 2006-03-18 23:23:53.000000000 +0100
@@ -1469,6 +1469,7 @@ static int parse_audio_selector_unit(str
kctl = snd_ctl_new1(&mixer_selectunit_ctl, cval);
if (! kctl) {
snd_printk(KERN_ERR "cannot malloc kcontrol\n");
+ kfree(namelist);
kfree(cval);
return -ENOMEM;
}
reply other threads:[~2006-03-18 22:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603182327.42389.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome