From: Denis Vlasenko <vda@ilport.com.ua>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Oliver Neukum" <oliver@neukum.org>,
"Arjan van de Ven" <arjan@infradead.org>,
"Matthew Wilcox" <matthew@wil.cx>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]use kzalloc in vfs where appropriate
Date: Mon, 20 Mar 2006 15:08:47 +0200 [thread overview]
Message-ID: <200603201508.47960.vda@ilport.com.ua> (raw)
In-Reply-To: <84144f020603192325h54fd3212l1f4846fd40b9f074@mail.gmail.com>
On Monday 20 March 2006 09:25, Pekka Enberg wrote:
> > Rewriting the test as:
> > n!=0 && n > INT_MAX / size
> > saves the division because size is much likelier to be a constant, and indeed
> > the code is better:
> >
> > cmpq $268435455, %rax
> > movq $0, 40(%rsp)
> > ja .L313
> >
> > Is there anything I am missing?
You may drop "n!=0" part, but you must check size!=0.
Since if size is 0, kcalloc returns NULL, then
if (!size || n > INT_MAX / size)
return NULL;
--
vda
next prev parent reply other threads:[~2006-03-20 13:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 20:58 Oliver Neukum
2006-03-17 21:08 ` Matthew Wilcox
2006-03-18 10:44 ` Oliver Neukum
2006-03-18 10:55 ` Arjan van de Ven
2006-03-19 13:29 ` Oliver Neukum
2006-03-19 16:09 ` Arjan van de Ven
2006-03-19 20:50 ` Oliver Neukum
2006-03-20 7:25 ` Pekka Enberg
2006-03-20 12:52 ` Oliver Neukum
2006-03-20 13:08 ` Denis Vlasenko [this message]
2006-03-20 13:14 ` Oliver Neukum
2006-03-20 13:23 ` Pekka J Enberg
2006-03-20 13:16 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603201508.47960.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=arjan@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=oliver@neukum.org \
--cc=penberg@cs.helsinki.fi \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome