mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: kenneth.w.chen@intel.com, suparna@in.ibm.com,
	zach.brown@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] direct-io: bug fix in dio handling write error
Date: Tue, 21 Mar 2006 15:13:04 -0800	[thread overview]
Message-ID: <20060321151304.4c3be798.akpm@osdl.org> (raw)
In-Reply-To: <1142974672.6086.15.camel@dyn9047017100.beaverton.ibm.com>

Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
> If some one asks to do IO for 128K and if we get -EIO after say, 64K 
> - we fail the whole IO  with -EIO ?

A multiple-block direct-IO can complete those blocks (actually the BIOs) in
any order.  How do we communicate to userspace that segments 0, 1, 3 and 5
completed OK, but segments 2 and 4 had errors?

The best we could do is to tell userspace that 0 and 1 completed and ignore
everything after the first I/O error.

But I don't think it's worth the effort.  Simply returning EIO for the
whole thing is probably good enough.  The only situation I can think of
where someone would care down to that level of detail is a specialised
recover-data-from-a-bad-disk application (for which direct-io would be a
good tool).  Such an application should have the brains to go
sector-at-a-time if larger I/O's throw errors.


      reply	other threads:[~2006-03-21 23:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-21  8:51 Chen, Kenneth W
2006-03-21 16:56 ` Badari Pulavarty
2006-03-21 19:03   ` Chen, Kenneth W
2006-03-21 20:57     ` Badari Pulavarty
2006-03-21 23:13       ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060321151304.4c3be798.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=suparna@in.ibm.com \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®