mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: jesper.juhl@gmail.com, penberg@cs.helsinki.fi,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist()  (try #3)
Date: Tue, 21 Mar 2006 17:46:23 -0800	[thread overview]
Message-ID: <20060321174623.2f92331b.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0603211732420.14503@schroedinger.engr.sgi.com>

Christoph Lameter <clameter@sgi.com> wrote:
>
> On Wed, 22 Mar 2006, Jesper Juhl wrote:
> 
> > Fix memory leak in mm/slab.c::alloc_kmemlist().
> > If one allocation fails we have to roll-back all allocations made up to the 
> > point of failure.
> 
> Sorry but you cannot roll back. alloc_kmemlist() could have been used for
> tuning the cpucache while accesses to the slab continue. "Rolling back" 
> would partially destroy the slab for some nodes and likely cause the 
> system to crash. We can only roll back if this is actually an initial 
> allocation and we are assured that the whole thing is not yet in use.

Well that's a big pickle.  How about allocating everything first, saving it
locally then, if that all worked out, install it?


  reply	other threads:[~2006-03-22  1:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-18 20:37 [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #2) Jesper Juhl
2006-03-19 18:40 ` Pekka Enberg
2006-03-20  8:55   ` Jesper Juhl
2006-03-22  0:54     ` [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3) Jesper Juhl
2006-03-22  1:10       ` Christoph Lameter
2006-03-22  1:35       ` Christoph Lameter
2006-03-22  1:46         ` Andrew Morton [this message]
2006-03-22  1:52           ` Christoph Lameter
2006-03-22  2:29           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060321174623.2f92331b.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome