From: Alasdair G Kergon <agk@redhat.com>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] Re: dm: bio split bvec fix
Date: Wed, 22 Mar 2006 12:19:41 +0000 [thread overview]
Message-ID: <20060322121941.GS26428@agk.surrey.redhat.com> (raw)
In-Reply-To: <20060322113235.GC4285@suse.de>
On Wed, Mar 22, 2006 at 12:32:35PM +0100, Jens Axboe wrote:
> Why isn't this just handled in the merge callback? Can a single page bio
> span > 2 targets?
Yes. (Unit of size if the sector - and things don't have to
be aligned nicely, just aligned to sector.)
IIRC the merge function assumes the number of bytes that can
be added is only a function of the offset: but in our case
it's also a function of time. To make this work it should
reserve those bytes with device-mapper, and guarantee either to
supply them to us subsequently (and preferably quickly) or to
cancel that reservation. Device-mapper for its part would
guarantee to accept the bio without needing to split it.
Or dm could have a rejection mechanism that refuses bios
that are too big (because the max number of bytes we accept
got reduced between the initial call and the bio actually being
presented) and they go back and get processed again.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2006-03-22 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 19:21 Alasdair G Kergon
2006-03-20 22:05 ` Andrew Morton
2006-03-22 11:32 ` Jens Axboe
2006-03-22 12:19 ` Alasdair G Kergon [this message]
2006-03-22 12:56 ` [dm-devel] " Jens Axboe
2006-03-22 13:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060322121941.GS26428@agk.surrey.redhat.com \
--to=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®