From: "Mark A. Greer" <mgreer@mvista.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Stephane@artesyncp.com, rmk+serial@arm.linux.org.uk
Subject: [PATCH 2.6.16-rc6-mm2] serial: mpsc driver has definition of SUPPORT_SYSRQ below include of serial_core.h
Date: Wed, 22 Mar 2006 12:08:28 -0700 [thread overview]
Message-ID: <20060322190828.GA22208@mag.az.mvista.com> (raw)
The definition of SUPPORT_SYSRQ must come before #include of serial_core.h.
This patch moves the definition of SUPPORT_SYSRQ to be just after the
#include of config.h to make it consistent with 8250.c.
Reported-by: Stephane Chazelas <Stephane@artesyncp.com>
Signed-off-by: Mark A. Greer <mgreer@mvista.com>
---
mpsc.h | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
---
diff -Nurp linux-2.6.16-rc6-mm2-mpsc_namefix/drivers/serial/mpsc.h linux-2.6.16-rc6-mm2-mpsc_sysrq/drivers/serial/mpsc.h
--- linux-2.6.16-rc6-mm2-mpsc_namefix/drivers/serial/mpsc.h 2006-03-11 15:12:55.000000000 -0700
+++ linux-2.6.16-rc6-mm2-mpsc_sysrq/drivers/serial/mpsc.h 2006-03-22 11:50:28.000000000 -0700
@@ -13,6 +13,11 @@
#define __MPSC_H__
#include <linux/config.h>
+
+#if defined(CONFIG_SERIAL_MPSC_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/tty.h>
@@ -31,10 +36,6 @@
#include <asm/io.h>
#include <asm/irq.h>
-#if defined(CONFIG_SERIAL_MPSC_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
#define MPSC_NUM_CTLRS 2
/*
reply other threads:[~2006-03-22 19:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060322190828.GA22208@mag.az.mvista.com \
--to=mgreer@mvista.com \
--cc=Stephane@artesyncp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®