From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 3/24] s390: channel path measurements.
Date: Thu, 23 Mar 2006 10:47:22 +0100 [thread overview]
Message-ID: <20060323104722.4183efbb@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20060322132655.79d85b61.akpm@osdl.org>
On Wed, 22 Mar 2006 13:26:55 -0800
Andrew Morton <akpm@osdl.org> wrote:
> hm, it's somewhat unusual for MAX_FOO to be inclusive. Usually it means
> "greatest possible+1".
__MAX_SUBCHANNEL and friends in drivers/s390/cio/css.h all use the same
semantics :)
> > +static inline int
> > +__chsc_do_secm(struct channel_subsystem *css, int enable, void *page)
>
> This has two callsites. inlining it probably deoptimises things.
OK.
>
> > + secm_area->request = (struct chsc_header) {
> > + .length = 0x0050,
> > + .code = 0x0016,
> > + };
>
> gcc tends to generate poor code for this construct.
Switching this to direct initialization seems to save a mvc. I'll
convert all instances in chsc.c for consistency.
Cornelia
next prev parent reply other threads:[~2006-03-23 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 15:15 Martin Schwidefsky
2006-03-22 21:26 ` Andrew Morton
2006-03-23 9:47 ` Cornelia Huck [this message]
2006-03-23 10:19 ` [patch] s390: channel path measurements fixups Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323104722.4183efbb@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®