From: Andrew Morton <akpm@osdl.org>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: linux-kernel@vger.kernel.org, micah@riseup.net, daniel@hozac.com
Subject: Re: [PATCH] mtd: fix broken name_to_dev_t() declaration
Date: Thu, 23 Mar 2006 15:46:25 -0800 [thread overview]
Message-ID: <20060323154625.16dfeb3f.akpm@osdl.org> (raw)
In-Reply-To: <20060323200205.GJ17981@MAIL.13thfloor.at>
Herbert Poetzl <herbert@13thfloor.at> wrote:
>
> drivers/mtd/devices/blkmtd.c uses a local declaration
> of name_to_dev_t() which is inconsistant with the real
> one. the following patch fixes this by removing the
> local declaration and including mount.h instead
OK..
Does that name_to_dev_t() call actually work? In my experience,
name_to_dev_t() just doesn't work if called at times other than during
early boot.
#ifdef MODULE
mode = (readonly) ? O_RDONLY : O_RDWR;
bdev = open_bdev_excl(devname, mode, NULL);
#else
mode = (readonly) ? FMODE_READ : FMODE_WRITE;
bdev = open_by_devnum(name_to_dev_t(devname), mode);
#endif
OK, I guess it still works at initcall-time. Still, the code is a bit,
err, innovative.
next prev parent reply other threads:[~2006-03-23 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 20:02 Herbert Poetzl
2006-03-23 23:46 ` Andrew Morton [this message]
2006-03-23 23:51 ` Herbert Poetzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323154625.16dfeb3f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=daniel@hozac.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=micah@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome