Hi. On Friday 24 March 2006 21:14, Jean Delvare wrote: > Hi Nigel, Andi, all, > > > It looks to me like the above commit from Andi causes a compilation > > failure on x86_64, because it makes pci_mmcfg_init non static: > > > > arch/x86_64/pci/mmconfig.c:152: error: conflicting types for > > ‘pci_mmcfg_init’ arch/i386/pci/pci.h:85: error: previous declaration of > > ‘pci_mmcfg_init’ was here > > make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1 > > make: *** [arch/x86_64/pci] Error 2 > > I just hit the same compilation failure. Here's a fix which works for > me. Yes, that's what I came up with too. Sent it a little earlier. Thanks for the confirmation that I did the right thing :) Nigel