mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: smp_locks reference_discarded errors
Date: Sat, 25 Mar 2006 23:50:35 -0800	[thread overview]
Message-ID: <20060325235035.5fcb902f.akpm@osdl.org> (raw)
In-Reply-To: <20060325033948.GA15564@redhat.com>

Dave Jones <davej@redhat.com> wrote:
>
> since the addition of smp alternatives, the following is occuring..
> 
> Error: ./drivers/md/md.o .smp_locks refers to 0000008c R_386_32          .exit.text
> Error: ./drivers/usb/storage/libusual.o .smp_locks refers to 00000008 R_386_32          .exit.text
> Error: ./net/802/psnap.o .smp_locks refers to 00000000 R_386_32          .exit.text
> Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 00000008 R_386_32          .exit.text
> Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 0000000c R_386_32          .exit.text
> 
> example .config at http://people.redhat.com/davej/kernel-2.6.16-i686-smp.config
> 

I guess an atomic operation in __exit code will cause that.  down() and
atomic_dec_and_test() in two cases.

I suspect most of these callsites are just wrongly coded - it's pretty
unusual for __exit code to really need to lock anything - what is there to
be racing against?

This is emitted by reference_discarded.pl?

  reply	other threads:[~2006-03-26  7:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-25  3:40 Dave Jones
2006-03-26  7:50 ` Andrew Morton [this message]
2006-03-26 15:40   ` Dave Jones
2006-03-26 16:10     ` Sam Ravnborg
2006-03-28  0:04       ` Dave Jones
2006-03-28  0:09         ` Randy.Dunlap
2006-03-31 19:08       ` Adrian Bunk
2006-03-31 19:33         ` Sam Ravnborg
2006-03-31 23:56           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060325235035.5fcb902f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome