From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Andrew Morton <akpm@osdl.org>
Cc: norsk5@xmission.com, dthompson@linuxnetworx.com, dsp@llnl.gov,
dave_peterson@pobox.com, linux-kernel@vger.kernel.org,
greg@kroah.com
Subject: Re: [PATCH] edac_752x needs CONFIG_HOTPLUG
Date: Mon, 27 Mar 2006 15:49:21 -0800 [thread overview]
Message-ID: <20060327154921.9f0a281d.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060327154055.564404f0.akpm@osdl.org>
On Mon, 27 Mar 2006 15:40:55 -0800 Andrew Morton wrote:
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> >
> > EDAC_752X uses pci_scan_single_device(), which is only available
> > if CONFIG_HOTPLUG is enabled
>
> hm. That's not a hotpluggable device, surely?
>
> If not then either a) PCI should be implementing pci_scan_single_device()
> if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().
or just that one if block should be surrounded by CONFIG_HOTPLUG
(done cleanly, of course).
---
~Randy
prev parent reply other threads:[~2006-03-27 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-27 23:06 Randy.Dunlap
2006-03-27 23:40 ` Andrew Morton
2006-03-27 23:49 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060327154921.9f0a281d.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=dave_peterson@pobox.com \
--cc=dsp@llnl.gov \
--cc=dthompson@linuxnetworx.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=norsk5@xmission.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®