From: Ashok Raj <ashok.raj@intel.com>
To: Nigel Cunningham <ncunningham@cyclades.com>
Cc: Ashok Raj <ashok.raj@intel.com>, Andrew Morton <akpm@osdl.org>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, rjw@sisk.pl
Subject: Re: [rfc] fix Kconfig, hotplug_cpu is needed for swsusp
Date: Wed, 29 Mar 2006 15:47:48 -0800 [thread overview]
Message-ID: <20060329154748.A12897@unix-os.sc.intel.com> (raw)
In-Reply-To: <200603300936.22757.ncunningham@cyclades.com>; from ncunningham@cyclades.com on Thu, Mar 30, 2006 at 09:36:16AM +1000
On Thu, Mar 30, 2006 at 09:36:16AM +1000, Nigel Cunningham wrote:
> Hi.
>
>
> So if you have a single core x86, you want X86_PC, and if you have HT or SMP,
> you want GENERICARCH? If so, could this be done via selects or depends or at
> least defaults in Kconfig?
Yes, i think only SUSPEND_SMP is affect by this. I thought Rafael cced Pavel during
that exchange, maybe i missed.
>
> Regards,
>
> Nigel
How about this patch.
Make SUSPEND_SMP depend on X86_GENERICARCH, since hotplug cpu requires !X86_PC
due to some race in IPI handling. See more discussion here
http://marc.theaimsgroup.com/?l=linux-kernel&m=114303306032338&w=2
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
--------------------------------------------------------------
Index: linux-2.6.16-git16/kernel/power/Kconfig
===================================================================
--- linux-2.6.16-git16.orig/kernel/power/Kconfig
+++ linux-2.6.16-git16/kernel/power/Kconfig
@@ -96,5 +96,5 @@ config SWSUSP_ENCRYPT
config SUSPEND_SMP
bool
- depends on HOTPLUG_CPU && X86 && PM
+ depends on HOTPLUG_CPU && X86 && PM && X86_GENERICARCH
default y
--
Cheers,
Ashok Raj
- Open Source Technology Center
next prev parent reply other threads:[~2006-03-29 23:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-29 22:08 Pavel Machek
2006-03-29 22:47 ` Andrew Morton
2006-03-29 23:09 ` Ashok Raj
2006-03-29 23:36 ` Nigel Cunningham
2006-03-29 23:47 ` Ashok Raj [this message]
2006-03-29 23:53 ` Nigel Cunningham
2006-03-30 0:12 ` Ashok Raj
2006-03-30 0:32 ` Nigel Cunningham
2006-03-30 0:13 ` Andrew Morton
2006-03-30 0:18 ` Nigel Cunningham
2006-03-30 3:01 ` Nigel Cunningham
[not found] ` <20060330030657.GA10405@mars.ravnborg.org>
2006-03-30 10:11 ` Roman Zippel
2006-03-30 8:24 ` Jan Engelhardt
2006-04-04 5:15 ` menuconfig search (Re: [rfc] fix Kconfig, hotplug_cpu is needed for swsusp) Randy.Dunlap
2006-04-04 6:01 ` Alexey Dobriyan
2006-04-04 15:12 ` Randy.Dunlap
2006-04-08 8:42 ` Jan Engelhardt
2006-04-09 2:29 ` Randy.Dunlap
2006-04-11 11:18 ` Jan Engelhardt
2006-03-30 8:41 ` [rfc] fix Kconfig, hotplug_cpu is needed for swsusp Pavel Machek
2006-03-30 16:17 ` Rafael J. Wysocki
2006-03-29 0:30 ` Pavel Machek
2006-04-01 23:55 ` Ashok Raj
2006-03-30 3:24 ` Andrew Morton
2006-03-30 13:00 ` Ashok Raj
2006-03-30 13:17 ` Pavel Machek
2006-03-30 13:05 ` Eric W. Biederman
2006-03-30 8:30 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060329154748.A12897@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@cyclades.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome