From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] splice support #3
Date: Thu, 30 Mar 2006 15:25:32 +0100 [thread overview]
Message-ID: <20060330142532.GB11934@infradead.org> (raw)
In-Reply-To: <20060330131530.GI13476@suse.de>
On Thu, Mar 30, 2006 at 03:15:30PM +0200, Jens Axboe wrote:
> Hi,
>
> Ok, this should be it, I hope. Fixed the remaining issues spotted by
> akpm, and also thanks to KAMEZAWA Hiroyuki for pointing out that the
> page moving logic could get confused.
Haven't looked at this in details, but two small comments already:
- generic_file_splice_read/write should probably go to filemap.c
where all the other generic pagecache file operations are
- could we try to replace ->sendfile and ->sendfile with the splice
operations completely? Having two different sets of zero-copy
file to file transfer mechanisms will make the code pretty messy.
next prev parent reply other threads:[~2006-03-30 14:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 13:15 Jens Axboe
2006-03-30 13:19 ` [PATCH] splice SPLICE_F_MOVE support Jens Axboe
2006-03-31 8:49 ` Nick Piggin
2006-03-31 19:53 ` Jens Axboe
2006-03-30 14:25 ` Christoph Hellwig [this message]
2006-03-30 14:37 ` [PATCH] splice support #3 Jens Axboe
[not found] <5W5ei-5kR-11@gated-at.bofh.it>
2006-03-31 0:08 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060330142532.GB11934@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®