From: Andrew Morton <akpm@osdl.org>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Introduce sys_splice() system call
Date: Thu, 30 Mar 2006 23:30:59 -0800 [thread overview]
Message-ID: <20060330233059.42ee1ae2.akpm@osdl.org> (raw)
In-Reply-To: <20060331071635.GA14022@suse.de>
Jens Axboe <axboe@suse.de> wrote:
>
> > > + ret = write_one_page(page, 0);
> >
> > Still want to know why this is here??
> >
> > > +out:
> > > + if (ret < 0)
> > > + unlock_page(page);
> >
> > If write_one_page()'s call to ->writepage() failed, this will cause a
> > double unlock.
>
> Can probably be improved - can I drop write_one_page() and just unlock
> the page and regular cleaning will flush it out?
>
Of course - commit_write() will mark the page dirty and it'll get flushed
back in the normal manner. We don't need that set_page_dirty() in there
either.
But we do need some O_SYNC/S_ISSYNC handling...
next prev parent reply other threads:[~2006-03-31 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200603302109.k2UL9Auj011419@hera.kernel.org>
2006-03-31 0:12 ` Andrew Morton
2006-03-31 7:16 ` Jens Axboe
2006-03-31 7:30 ` Andrew Morton [this message]
2006-03-31 7:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060330233059.42ee1ae2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome