From: David Brownell <david-b@pacbell.net>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: [patch 2.6.16-git] dma doc updates
Date: Sun, 2 Apr 2006 08:21:43 -0800 [thread overview]
Message-ID: <200604020921.44095.david-b@pacbell.net> (raw)
In-Reply-To: <20060402025124.GI25945@granada.merseine.nu>
On Saturday 01 April 2006 6:51 pm, Muli Ben-Yehuda wrote:
> On Sat, Apr 01, 2006 at 10:21:52AM -0800, David Brownell wrote:
>
> > + int
> > + dma_map_sg(struct device *dev, struct scatterlist *sg,
> > + int nents, enum dma_data_direction direction)
>
> While you're at it, care to s/enum dma_data_direction/int/? some archs
> use one and some use the other, and there was weak consensus that int
> is better.
Nah. That patch was just to _clarify_ things not make API changes.
That particular text was just being indented for readability.
Plus, I won't join a consensus to needlessly prevent compilers from
reporting illegal parameters.
- Dave
next prev parent reply other threads:[~2006-04-02 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 18:21 David Brownell
2006-04-02 2:51 ` Muli Ben-Yehuda
2006-04-02 16:21 ` David Brownell [this message]
2006-04-03 22:45 ` patch dma-doc-updates.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604020921.44095.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®