From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: rmk+lkml@arm.linux.org.uk
Cc: pavel@ucw.cz, rpurdie@rpsys.net, lenz@cs.wisc.edu,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: include/asm-arm/memory.h changes break zaurus sl-5500 boot
Date: Mon, 3 Apr 2006 17:56:03 +0900 [thread overview]
Message-ID: <20060403175603.7a3dd64f.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20060403164434.fdb5020c.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, 3 Apr 2006 16:44:34 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Mon, 3 Apr 2006 08:36:53 +0100
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> Hmm..from include/asm-arm/arch-clps711x/memory.h
>
> ==
> /*
> * Given a kaddr, LOCAL_MAR_NR finds the owning node of the memory
> * and returns the index corresponding to the appropriate page in the
> * node's mem_map.
> */
> #define LOCAL_MAP_NR(addr) \
> (((unsigned long)(addr) & (NODE_MAX_MEM_SIZE - 1)) >> PAGE_SHIFT)
> ==
>
> Is this comment wrong ???
>
Russell-san
All of sub-arch's comment says "Given a kaddr" but all of them just uses "offset".
So, paddr can be given as arg.
__va()(or pfn_to_kaddr()) adds unnecessary calcs, so paddr should be used instead of kaddr.
Right ?
-Kame
next prev parent reply other threads:[~2006-04-03 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-02 21:00 Pavel Machek
2006-04-02 22:08 ` Russell King
2006-04-02 22:23 ` Pavel Machek
2006-04-02 23:53 ` KAMEZAWA Hiroyuki
2006-04-03 0:15 ` KAMEZAWA Hiroyuki
2006-04-03 7:36 ` Russell King
2006-04-03 7:44 ` KAMEZAWA Hiroyuki
2006-04-03 8:56 ` KAMEZAWA Hiroyuki [this message]
2006-04-03 9:02 ` Russell King
2006-04-03 9:08 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060403175603.7a3dd64f.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®