From: Adrian Bunk <bunk@stusta.de>
To: hjlipp@web.de, tilman@imap.cc
Cc: gigaset307x-common@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kkeil@suse.de,
isdn4linux@listserv.isdn4linux.de
Subject: [2.6 patch] drivers/isdn/gigaset/common.c: small cleanups
Date: Tue, 4 Apr 2006 18:29:15 +0200 [thread overview]
Message-ID: <20060404162915.GJ6529@stusta.de> (raw)
This patch contains the following cleanups:
- makethe needlessly global gigaset_get_cs_by_tty() static
- remove the unused EXPORT_SYMBOL_GPL(gigaset_debugdrivers)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/isdn/gigaset/common.c | 17 ++++++++---------
drivers/isdn/gigaset/gigaset.h | 1 -
2 files changed, 8 insertions(+), 10 deletions(-)
--- linux-2.6.16-mm2-full/drivers/isdn/gigaset/gigaset.h.old 2006-04-04 00:15:36.000000000 +0200
+++ linux-2.6.16-mm2-full/drivers/isdn/gigaset/gigaset.h 2006-04-04 00:15:42.000000000 +0200
@@ -754,7 +754,6 @@
/* Deallocate driver structure. */
void gigaset_freedriver(struct gigaset_driver *drv);
void gigaset_debugdrivers(void);
-struct cardstate *gigaset_get_cs_by_minor(unsigned minor);
struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty);
struct cardstate *gigaset_get_cs_by_id(int id);
--- linux-2.6.16-mm2-full/drivers/isdn/gigaset/common.c.old 2006-04-04 00:06:34.000000000 +0200
+++ linux-2.6.16-mm2-full/drivers/isdn/gigaset/common.c 2006-04-04 00:16:45.000000000 +0200
@@ -962,16 +962,8 @@
}
spin_unlock_irqrestore(&driver_lock, flags);
}
-EXPORT_SYMBOL_GPL(gigaset_debugdrivers);
-struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty)
-{
- if (tty->index < 0 || tty->index >= tty->driver->num)
- return NULL;
- return gigaset_get_cs_by_minor(tty->index + tty->driver->minor_start);
-}
-
-struct cardstate *gigaset_get_cs_by_minor(unsigned minor)
+static struct cardstate *gigaset_get_cs_by_minor(unsigned minor)
{
unsigned long flags;
static struct cardstate *ret = NULL;
@@ -994,6 +986,13 @@
return ret;
}
+struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty)
+{
+ if (tty->index < 0 || tty->index >= tty->driver->num)
+ return NULL;
+ return gigaset_get_cs_by_minor(tty->index + tty->driver->minor_start);
+}
+
void gigaset_freedriver(struct gigaset_driver *drv)
{
unsigned long flags;
next reply other threads:[~2006-04-04 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-04 16:29 Adrian Bunk [this message]
2006-04-05 9:38 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060404162915.GJ6529@stusta.de \
--to=bunk@stusta.de \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome