From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Greg KH <gregkh@suse.de>
Cc: rene.herman@keyaccess.nl, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, tiwai@suse.de
Subject: Re: patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree
Date: Tue, 4 Apr 2006 21:59:12 -0400 [thread overview]
Message-ID: <200604042159.12479.dtor_core@ameritech.net> (raw)
In-Reply-To: <20060404214522.GA20390@suse.de>
On Tuesday 04 April 2006 17:45, Greg KH wrote:
> > But why do we do that? probe() failing is driver's problem. The device
> > is still there and should still be presented in sysfs. I don't think
> > that we should stop if probe() fails - maybe next driver manages to
> > bind itself.
>
> The device is still there.
>
> Ah, I see what you are saying now. Yeah, we should still add the
> default attributes for the bus and create the bus link even if some
> random driver had problems.
Not only that, but device will be killed as well - if bus_add_device()
fails device_add() branches into BusError which leads to kobject_del().
--
Dmitry
next prev parent reply other threads:[~2006-04-05 1:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 5:32 bus_add_device() losing an error return from the probe() method Rene Herman
2006-03-26 1:53 ` Andrew Morton
2006-03-26 22:30 ` Rene Herman
2006-04-04 19:10 ` patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree gregkh
2006-04-04 20:23 ` Dmitry Torokhov
2006-04-04 21:00 ` Greg KH
2006-04-04 21:15 ` Greg KH
2006-04-04 21:22 ` Andrew Morton
2006-04-04 21:28 ` Dmitry Torokhov
2006-04-04 21:45 ` Greg KH
2006-04-05 1:35 ` Dmitry Torokhov
2006-04-05 7:36 ` Russell King
2006-04-06 1:05 ` Greg KH
2006-04-05 1:59 ` Dmitry Torokhov [this message]
2006-04-04 22:12 ` Rene Herman
2006-04-05 0:23 ` Rene Herman
2006-04-05 1:45 ` Dmitry Torokhov
2006-04-05 18:36 ` Rene Herman
2006-04-05 18:44 ` Dmitry Torokhov
2006-04-05 1:48 ` Dmitry Torokhov
2006-04-05 13:50 ` Rene Herman
2006-04-05 14:59 ` Dmitry Torokhov
2006-04-05 21:22 ` Rene Herman
2006-04-05 13:55 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604042159.12479.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome