From: Sam Ravnborg <sam@ravnborg.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Adrian Bunk <bunk@stusta.de>,
perex@suse.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] move EXPORT_SYMBOL's away from sound/pci/emu10k1/emu10k1_main.c
Date: Fri, 7 Apr 2006 20:49:09 +0200 [thread overview]
Message-ID: <20060407184909.GB9097@mars.ravnborg.org> (raw)
In-Reply-To: <s5hu095y367.wl%tiwai@suse.de>
On Fri, Apr 07, 2006 at 02:34:56PM +0200, Takashi Iwai wrote:
> At Fri, 7 Apr 2006 02:31:05 +0200,
> Adrian Bunk wrote:
> >
> > This patch moves the EXPORT_SYMBOL's from
> > sound/pci/emu10k1/emu10k1_main.c to the files with the actual functions.
>
> What is the merit of this movement?
1) Documentation - it is obvious that the function/data is exported so
be a bit mroe careful when introducing changes
2) Style. In 2.6 the preferred style is to put the EXPORT_SYMBOL on the
line following the closing } of the exported function.
3) Keep changes local. If one removes a previously exported symbol less
files needs to be touched.
Sam
next prev parent reply other threads:[~2006-04-07 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 0:31 Adrian Bunk
2006-04-07 12:34 ` Takashi Iwai
2006-04-07 18:49 ` Sam Ravnborg [this message]
2006-04-10 9:55 ` Takashi Iwai
2006-04-10 16:21 ` Arjan van de Ven
2006-04-11 10:40 ` Takashi Iwai
2006-04-10 17:22 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060407184909.GB9097@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=alsa-devel@alsa-project.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®