mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Ingo Molnar <mingo@elte.hu>,
	"Paul E. McKenney" <paulmck@us.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] coredump: kill ptrace related stuff
Date: Sun,  9 Apr 2006 21:54:51 -0700 (PDT)	[thread overview]
Message-ID: <20060410045451.434ED1809D1@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Friday, 7 April 2006 02:06:31 +0400 <20060406220631.GA240@oleg>

> With this patch zap_process() sets SIGNAL_GROUP_EXIT while sending
> SIGKILL to the thread group. 

do_coredump has already done this.  So you are addressing the case of other
thread groups sharing the mm, right?

> This means that a TASK_TRACED task
> 
> 	1. Will be awakened by signal_wake_up(1)

That should always happen regardless of signal->flags, so yes.

> 	2. Can't sleep again via ptrace_notify()

What makes this be so?  What if it's entering a notification event now?
What about exit tracing?

> 	3. Can't go to do_signal_stop() after return
> 	   from ptrace_stop() in get_signal_to_deliver()

This is only true because of the check in get_signal_to_deliver,
which I've said I think should be taken out for other reasons.

I guess I'm missing something here.


Thanks,
Roland

  reply	other threads:[~2006-04-10  4:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-06 22:06 Oleg Nesterov
2006-04-10  4:54 ` Roland McGrath [this message]
2006-04-10 13:35   ` Oleg Nesterov
2006-04-11  1:21     ` Roland McGrath
2006-04-13 12:58       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060410045451.434ED1809D1@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=paulmck@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®