mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Ingo Molnar <mingo@elte.hu>,
	"Paul E. McKenney" <paulmck@us.ibm.com>,
	Andrew Morton <akpm@osdl.org>, Lee Revell <rlrevell@joe-job.com>
Subject: Re: [PATCH rc1-mm 1/3] coredump: some code relocations
Date: Sun,  9 Apr 2006 23:56:38 -0700 (PDT)	[thread overview]
Message-ID: <20060410065638.EEB1F1809CB@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Sunday, 9 April 2006 04:11:20 +0400 <20060409001120.GA98@oleg>

> This is a preparation for the next patch. No functional changes.
> Basically, this patch moves '->flags & SIGNAL_GROUP_EXIT' check
> into zap_threads(), and 'complete(vfork_done)' into coredump_wait
> outside of ->mmap_sem protected area.
> 
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

I don't see anything especially wrong with these reorganizations.  I'd
prefer if the commentary for the change indicated what about them was
required for the following patches.  Making zap_threads have a return value
does seem sort of random and obfuscatory, but that is a minor nit.


Thanks,
Roland

      reply	other threads:[~2006-04-10  6:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-09  0:11 Oleg Nesterov
2006-04-10  6:56 ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060410065638.EEB1F1809CB@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=paulmck@us.ibm.com \
    --cc=rlrevell@joe-job.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome