Re: [PATCH 1/1] POWERPC: Fix ppc32 compile with gcc+SSP in 2.6.16

[John Mylchreest <johnm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

On Tue, Apr 04, 2006 at 12:58:26PM +0200, Olaf Hering <olh@suse.de> wrote:
>  On Tue, Apr 04, John Mylchreest wrote:
> 
> > On Tue, Apr 04, 2006 at 11:41:24AM +0200, Olaf Hering <olh@suse.de> wrote:
> > > I think this should go into the main makefile, HOSTCFLAGS or similar. If
> > > you look around quickly in the gentoo bugzilla, all non-userland
> > > packages (grub, xen, kernel etc.) require the -fno-feature.
> > 
> > I'm not completely sure I understand where you are coming from here?
> > I assume you mean adding -fno-stack-protector to the host userlands
> > CFLAGS variable (or similar) to make it a global change, but if so
> > you're missing my point.
> 
> I mean the whole kernel should be compiled with it, if you put it into
> global cflags, the boot parts will pick it up from there.

Sorry, for the belated reply. I thought that might be what you refered to,
however I think this is going to cause additional problems. The powerpc
code which is effected uses the CROSS32CC which may, or may not be the
same compiler as used by the host cc. This means that it could also have
different capabilities, and the worst scenario in this specific
situation would be where the hostcc didn't support ssp, but the
cross32cc did, and had it enforced.

I don't think this is the right approach, and keeping it isolated to the
boot code makes more sense to me.

-- 
Role:            Gentoo Linux Kernel Lead
Gentoo Linux:    http://www.gentoo.org
Public Key:      gpg --recv-keys 9C745515
Key fingerprint: A0AF F3C8 D699 A05A EC5C  24F7 95AA 241D 9C74 5515


[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]