mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Aubrey <aubreylee@gmail.com>
Cc: Erik Mouw <erik@harddisk-recovery.com>, linux-kernel@vger.kernel.org
Subject: Re: The assemble file under the driver folder can not be recognized when the driver is built as module
Date: Mon, 10 Apr 2006 19:33:06 +0200	[thread overview]
Message-ID: <20060410173306.GB8612@mars.ravnborg.org> (raw)
In-Reply-To: <6d6a94c50604100627q297b7335yb58288356aaa8edd@mail.gmail.com>

On Mon, Apr 10, 2006 at 09:27:18PM +0800, Aubrey wrote:
> On 4/10/06, Erik Mouw <erik@harddisk-recovery.com> wrote:
> > On Mon, Apr 10, 2006 at 06:16:56PM +0800, Aubrey wrote:
> > Why would you write a driver in assembly in the first place? That makes
> > it highly unportable, I bet you can't compile your driver for x86 and
> > ARM from the same source. There are only four drivers in the whole
> > kernel tree that have an assembly part, but those are so tied to their
> > platform (Acorn, Amiga) that they aren't portable anyway.
> 
> Yes, the driver isn't portable. I'm working on the blackfin linux
> system. The driver is written mostly by c except one codec. You know,
> blackfin has DSP instruction set, so I write the codec in assembly to
> improve my driver's performance.
> >
> > I haven't seen your Makefile so I can't see what's wrong, but see
> > drivers/scsi/arm/Makefile for an example.
> >
> Makefile is simple.
> ===============================
> ----snip----
> obj-$(CONFIG_FB_BFIN_7171)	  += bfin_ad7171fb.o rgb2ycbcr.o
> ----snip----
> ===============================
> There are two files, bfin_ad7171fb.c and rgb2ycbcr.S under the folder
> " ./drivers/video".
> It should be OK because the driver can pass the compilation when
> select it as built-in.
What you say with the above is that you want to create two modules.
One module named: bfin_ad7171fb
and another module named: rgb2ycbcr

But kbuild does not support creating modules based on a .S file alone.
What I expect you to say is that you have one module named: bfin_7171
this is expressed like this:

obj-$(CONFIG_FB_BFIN_7171) += bfin_7171.o
bfin_7171-y := bfin_ad7171fb.o rgb2ycbcr.o

And then it works with your .S file.

	Sam

  reply	other threads:[~2006-04-10 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-10 10:16 Aubrey
2006-04-10 11:28 ` Erik Mouw
2006-04-10 13:27   ` Aubrey
2006-04-10 17:33     ` Sam Ravnborg [this message]
2006-04-10 17:42     ` Adrian Bunk
2006-04-10 18:04       ` linux-os (Dick Johnson)
2006-04-10 18:24         ` Sam Ravnborg
2006-04-10 19:12           ` linux-os (Dick Johnson)
2006-04-10 19:30             ` Sam Ravnborg
2006-04-11  2:58         ` Aubrey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060410173306.GB8612@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=aubreylee@gmail.com \
    --cc=erik@harddisk-recovery.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®