From: Mike Kravetz <mjkravetz@verizon.net>
To: Andrew Morton <akpm@osdl.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Joel H Schopp <jschopp@us.ibm.com>,
Dave Hansen <haveblue@us.ibm.com>,
Andy Whitcroft <apw@shadowen.org>,
lhms-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] sparsemem interaction with memory add bug fixes
Date: Tue, 11 Apr 2006 19:33:47 -0700 [thread overview]
Message-ID: <20060412023347.GA9343@w-mikek2.ibm.com> (raw)
This patch fixes two bugs with the way sparsemem interacts with memory
add. They are:
- memory leak if memmap for section already exists
- calling alloc_bootmem_node() after boot
These bugs were discovered and a first cut at the fixes were provided by
Arnd Bergmann <arnd@arndb.de> and Joel Schopp <jschopp@us.ibm.com>.
Signed-off-by: Mike Kravetz <kravetz@us.ibm.com>
diff -Naupr linux-2.6.17-rc1-mm2/mm/sparse.c linux-2.6.17-rc1-mm2.work/mm/sparse.c
--- linux-2.6.17-rc1-mm2/mm/sparse.c 2006-04-03 03:22:10.000000000 +0000
+++ linux-2.6.17-rc1-mm2.work/mm/sparse.c 2006-04-11 23:32:10.000000000 +0000
@@ -32,7 +32,10 @@ static struct mem_section *sparse_index_
unsigned long array_size = SECTIONS_PER_ROOT *
sizeof(struct mem_section);
- section = alloc_bootmem_node(NODE_DATA(nid), array_size);
+ if (system_state == SYSTEM_RUNNING)
+ section = kmalloc_node(array_size, GFP_KERNEL, nid);
+ else
+ section = alloc_bootmem_node(NODE_DATA(nid), array_size);
if (section)
memset(section, 0, array_size);
@@ -281,9 +284,9 @@ int sparse_add_one_section(struct zone *
ret = sparse_init_one_section(ms, section_nr, memmap);
+out:
if (ret <= 0)
__kfree_section_memmap(memmap, nr_pages);
-out:
pgdat_resize_unlock(pgdat, &flags);
return ret;
}
next reply other threads:[~2006-04-12 2:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 2:33 Mike Kravetz [this message]
2006-04-12 9:32 ` [Lhms-devel] " jschopp
2006-04-12 13:22 ` Andy Whitcroft
2006-04-12 13:43 ` jschopp
2006-04-12 14:46 ` Dave Hansen
2006-04-12 16:05 ` [Lhms-devel] " Mike Kravetz
2006-04-12 17:19 Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412023347.GA9343@w-mikek2.ibm.com \
--to=mjkravetz@verizon.net \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=arnd@arndb.de \
--cc=haveblue@us.ibm.com \
--cc=jschopp@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®