From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: "Luca Falavigna" <dktrkranz@gmail.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CONSOLE_LP_STRICT Kconfig option
Date: Wed, 12 Apr 2006 12:09:04 -0700 [thread overview]
Message-ID: <20060412120904.e2fce912.rdunlap@xenotime.net> (raw)
In-Reply-To: <ff1cadb20604121153k6552ea84maf58b44869412f2@mail.gmail.com>
On Wed, 12 Apr 2006 20:53:28 +0200 Luca Falavigna wrote:
> 2006/4/12, Randy.Dunlap <rdunlap@xenotime.net>:
> > On Wed, 15 Feb 2006 10:03:30 +0100 Luca Falavigna wrote:
> >
> > > Oops, I noticed I sent twice my email. Sorry.
> > >
> > > 14 Feb 2006 15:59:56 +0100, Andi Kleen <ak@suse.de>:
> > > > This shouldn't be a CONFIG. This should be a runtime option.
> > > > It's ridiculous to have to recompile your kernel just to fix some
> > > > problem with your printer.
> > > >
> > > > e.g. sysctl, ioctl, sysfs entry, module parameter. Whatever is en
> > > > vogue these days. Easiest would be probably a module_param().
> > >
> > > This feature only gets involved when passing console=lp0 parameter to
> > > the bootloader. I never tried to load a new system console while
> > > system was running so I'm not sure if it behaves correctly. If it
> > > does, I will modify this patch following your advices.
> >
> > Andi's suggestion seems fine to me: use a module_param() for
> > CONSOLE_LP_STRICT instead of a hidden build-time (non-Kconfig)
> > option. Are you interested in making this change?
> >
> > ---
>
> I can give it a try. I'm not sure if this can be done when system is loaded.
I think that if you make it a module_param() and use (root-) writeable
permissions on it, it's just a variable that can be changed after the
driver is loaded and running.
Andi, did you want just a boot-time option or a run-time (changeable) option?
---
~Randy
next prev parent reply other threads:[~2006-04-12 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 14:46 Luca Falavigna
2006-02-14 14:59 ` Andi Kleen
2006-02-15 9:03 ` Luca Falavigna
2006-04-11 22:17 ` Randy.Dunlap
[not found] ` <ff1cadb20604121153k6552ea84maf58b44869412f2@mail.gmail.com>
2006-04-12 19:09 ` Randy.Dunlap [this message]
2006-04-13 22:45 ` Luca Falavigna
2006-02-14 21:05 Luca Falavigna
2006-02-15 3:33 ` Randy.Dunlap
2006-02-15 8:29 ` Luca Falavigna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412120904.e2fce912.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=ak@suse.de \
--cc=dktrkranz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®