From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964799AbWDMF2y (ORCPT ); Thu, 13 Apr 2006 01:28:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964800AbWDMF2y (ORCPT ); Thu, 13 Apr 2006 01:28:54 -0400 Received: from xenotime.net ([66.160.160.81]:21973 "HELO xenotime.net") by vger.kernel.org with SMTP id S964799AbWDMF2x (ORCPT ); Thu, 13 Apr 2006 01:28:53 -0400 Date: Wed, 12 Apr 2006 22:31:19 -0700 From: "Randy.Dunlap" To: "Randy.Dunlap" Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, minyard@mvista.com Subject: [PATCH] IPMI: fix devinit placement (take 2) Message-Id: <20060412223119.e0aaf78e.rdunlap@xenotime.net> In-Reply-To: <20060412110557.dc03c0f8.rdunlap@xenotime.net> References: <20060412110557.dc03c0f8.rdunlap@xenotime.net> Organization: YPO4 X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.3; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap gcc complains about __devinit in the wrong location: drivers/char/ipmi/ipmi_si_intf.c:2205: warning: '__section__' attribute does not apply to types Actually for data it should be __devinitdata instead of __devinit. Otherwise it causes another gcc section mismatch error. Signed-off-by: Randy Dunlap --- drivers/char/ipmi/ipmi_si_intf.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- linux-2617-rc1g5.orig/drivers/char/ipmi/ipmi_si_intf.c +++ linux-2617-rc1g5/drivers/char/ipmi/ipmi_si_intf.c @@ -2198,11 +2198,11 @@ static inline void wait_for_timer_and_th } } -static struct ipmi_default_vals +static __devinitdata struct ipmi_default_vals { int type; int port; -} __devinit ipmi_defaults[] = +} ipmi_defaults[] = { { .type = SI_KCS, .port = 0xca2 }, { .type = SI_SMIC, .port = 0xca9 }, ---