From: "David S. Miller" <davem@davemloft.net>
To: bunk@stusta.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] net/netlink/: possible cleanups
Date: Thu, 13 Apr 2006 13:26:03 -0700 (PDT) [thread overview]
Message-ID: <20060413.132603.94193712.davem@davemloft.net> (raw)
In-Reply-To: <20060413162710.GE4162@stusta.de>
From: Adrian Bunk <bunk@stusta.de>
Date: Thu, 13 Apr 2006 18:27:10 +0200
> This patch contains the following possible cleanups plus changes related
> to them:
> - make the following needlessly global functions static:
> - attr.c: __nla_reserve()
> - attr.c: __nla_put()
> - #if 0 the following unused global functions:
> - attr.c: nla_validate()
> - attr.c: nla_find()
> - attr.c: nla_memcpy()
> - attr.c: nla_memcmp()
> - attr.c: nla_strcmp()
> - attr.c: nla_reserve()
> - genetlink.c: genl_unregister_ops()
> - remove the following unused EXPORT_SYMBOL's:
> - af_netlink.c: netlink_set_nonroot
> - attr.c: nla_parse
> - attr.c: nla_strlcpy
> - attr.c: nla_put
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Bunk-bot, you have to stop.
These interfaces were added so that new users of netlink could
write their code more easily.
Unused does not equate to "comment out or delete".
next prev parent reply other threads:[~2006-04-13 20:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 16:27 Adrian Bunk
2006-04-13 20:26 ` David S. Miller [this message]
2006-04-14 10:32 ` Adrian Bunk
2006-04-14 10:56 ` Evgeniy Polyakov
2006-04-18 14:19 ` Adrian Bunk
2006-04-18 18:48 ` Alan Cox
2006-04-18 19:09 ` Adrian Bunk
2006-04-19 0:02 ` Philip Craig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413.132603.94193712.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®