From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: jgarzik@pobox.com, jeff@garzik.org, Andrew Morton <akpm@osdl.org>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH][resend] Fix potential NULL pointer deref in gen_init_cpio
Date: Thu, 13 Apr 2006 14:34:36 +0200 [thread overview]
Message-ID: <200604131434.36405.jesper.juhl@gmail.com> (raw)
(This patch was already send before on Mar 18, this is a resend)
Fix potential NULL pointer deref in gen_init_cpio.c spotted by
coverity checker.
This fixes coverity bug #86
Without this patch we risk dereferencing a NULL `type' in the
"if ('\n' == *type) {" line.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
usr/gen_init_cpio.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.17-rc1-git7-orig/usr/gen_init_cpio.c 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.17-rc1-git7/usr/gen_init_cpio.c 2006-04-13 14:27:51.000000000 +0200
@@ -471,6 +471,7 @@ int main (int argc, char *argv[])
"ERROR: incorrect format, could not locate file type line %d: '%s'\n",
line_nr, line);
ec = -1;
+ break;
}
if ('\n' == *type) {
@@ -506,7 +507,8 @@ int main (int argc, char *argv[])
line_nr, line);
}
}
- cpio_trailer();
+ if (ec == 0)
+ cpio_trailer();
exit(ec);
}
reply other threads:[~2006-04-13 12:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604131434.36405.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome