From: Tim Phipps <tim@phipps-hutton.freeserve.co.uk>
To: "Linus Torvalds" <torvalds@osdl.org>
Cc: "Jesper Juhl" <jesper.juhl@gmail.com>,
"Mike Galbraith" <efault@gmx.de>,
linux-kernel@vger.kernel.org, "Edgar Toernig" <froese@gmx.de>,
"Dave Jones" <davej@redhat.com>
Subject: [PATCH 001/001] cpufreq: p4_clockmod errata N60 handling is over zealous
Date: Thu, 13 Apr 2006 14:59:38 +0100 [thread overview]
Message-ID: <200604131459.41354.tim@phipps-hutton.freeserve.co.uk> (raw)
In-Reply-To: <9a8748490604130542y783e604ew93aea8e4997c3f57@mail.gmail.com>
From: Tim Phipps <tim@phipps-hutton.freeserve.co.uk>
> > On Wednesday 05 Apr 2006 14:59, Mike Galbraith wrote:
> > > On Wed, 2006-04-05 at 13:02 +0100, Tim Phipps wrote:
> > > > Here's a patch to 2.6.17-rc1 that disables the 12.5% DC on any CPU
> > > > that has N60. The frequencies in the errata are a bit vague so this
> > > > is the safe bet and it only disables one of the eight frequencies
> > > > rather than the current behaviour which disables all of mine!
> > >
> > > Works for me. Perhaps you should update...
> > > dprintk("has errata -- disabling frequencies lower than 2ghz\n");
> > > ...,slap a Signed-off-by: on it and see if it flys.
Signed-off-by: Tim Phipps <tim@phipps-hutton.freeserve.co.uk>
---
--- linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.orig
2006-04-10 17:12:23.000000000 +0100
+++ linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c 2006-04-10
17:23:44.000000000 +0100
@@ -17,6 +17,7 @@
*
* Date Errata Description
* 20020525 N44, O17 12.5% or 25% DC causes lockup
+ * 20060410 N60 12.5% DC causes lockup
*
*/
@@ -231,7 +232,7 @@ static int cpufreq_p4_cpu_init(struct cp
case 0x0f29:
has_N60_errata[policy->cpu] = 1;
- dprintk("has errata -- disabling frequencies lower than 2GHz\n");
+ dprintk("has errata -- disabling 12.5%% duty cycle\n");
break;
}
@@ -244,7 +245,7 @@ static int cpufreq_p4_cpu_init(struct cp
for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) {
if ((i<2) && (has_N44_O17_errata[policy->cpu]))
p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID;
- else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000)
+ else if ((i<2) && has_N60_errata[policy->cpu])
p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID;
else
p4clockmod_table[i].frequency = (stock_freq * i)/8;
prev parent reply other threads:[~2006-04-13 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 20:55 p4-clockmod not working in 2.6.16 Sasa Ostrouska
2006-03-21 21:01 ` Dave Jones
2006-03-21 21:57 ` Sasa Ostrouska
2006-03-21 21:59 ` Arjan van de Ven
2006-03-21 22:52 ` Sasa Ostrouska
2006-03-21 22:01 ` Dave Jones
2006-03-21 22:08 ` Sasa Ostrouska
2006-03-21 22:13 ` Sasa Ostrouska
2006-03-21 22:20 ` Dave Jones
2006-03-21 22:51 ` Sasa Ostrouska
2006-03-22 5:57 ` Edgar Toernig
2006-03-22 6:20 ` Mike Galbraith
[not found] ` <1144147663.2588.247.camel@elsdt-scarecrow.arc.com>
2006-04-05 12:02 ` Tim Phipps
[not found] ` <1144245205.7571.11.camel@homer>
2006-04-05 13:59 ` Mike Galbraith
2006-04-13 12:20 ` Tim Phipps
2006-04-13 12:42 ` Jesper Juhl
2006-04-13 13:59 ` Tim Phipps [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604131459.41354.tim@phipps-hutton.freeserve.co.uk \
--to=tim@phipps-hutton.freeserve.co.uk \
--cc=davej@redhat.com \
--cc=efault@gmx.de \
--cc=froese@gmx.de \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome