From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Andrew Morton <akpm@osdl.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: [PATCH 2/4] Make mtdblock_ro unconditionally readonly
Date: Thu, 13 Apr 2006 18:53:55 +0200 [thread overview]
Message-ID: <20060413165355.GF30574@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20060413165153.GD30574@wohnheim.fh-wedel.de>
mtdblock_ro is by definition readonly. Remove the silly checks.
Signed-off-by: Jörn Engel <joern@wohnheim.fh-wedel.de>
---
drivers/mtd/mtdblock_ro.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- mtd_type/drivers/mtd/mtdblock_ro.c~mtdblock_ro 2006-04-13 17:56:54.000000000 +0200
+++ mtd_type/drivers/mtd/mtdblock_ro.c 2006-04-13 17:57:31.000000000 +0200
@@ -45,9 +45,7 @@ static void mtdblock_add_mtd(struct mtd_
dev->blksize = 512;
dev->size = mtd->size >> 9;
dev->tr = tr;
- if ((mtd->flags & (MTD_CLEAR_BITS|MTD_SET_BITS|MTD_WRITEABLE)) !=
- (MTD_CLEAR_BITS|MTD_SET_BITS|MTD_WRITEABLE))
- dev->readonly = 1;
+ dev->readonly = 1;
add_mtd_blktrans_dev(dev);
}
next prev parent reply other threads:[~2006-04-13 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 16:51 [PATCH 0/4] Cleanup of mtd->type and mtd->flags Jörn Engel
2006-04-13 16:53 ` [PATCH 1/4] Simplify test for RAM devices Jörn Engel
2006-04-13 16:53 ` Jörn Engel [this message]
2006-04-13 16:54 ` [PATCH 3/4] Remove unchecked flags Jörn Engel
2006-04-13 18:08 ` Josh Boyer
2006-04-13 19:18 ` David Woodhouse
2006-04-13 21:50 ` Josh Boyer
2006-04-13 16:55 ` [PATCH 4/4] Remove unused types Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413165355.GF30574@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®