From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965088AbWDNBSj (ORCPT ); Thu, 13 Apr 2006 21:18:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965093AbWDNBSj (ORCPT ); Thu, 13 Apr 2006 21:18:39 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:28372 "EHLO fgwmail5.fujitsu.co.jp") by vger.kernel.org with ESMTP id S965088AbWDNBSi (ORCPT ); Thu, 13 Apr 2006 21:18:38 -0400 Date: Fri, 14 Apr 2006 10:19:58 +0900 From: KAMEZAWA Hiroyuki To: Christoph Lameter Cc: akpm@osdl.org, hugh@veritas.com, linux-kernel@vger.kernel.org, lee.schermerhorn@hp.com, linux-mm@kvack.org, clameter@sgi.com, taka@valinux.co.jp, marcelo.tosatti@cyclades.com Subject: Re: [PATCH 5/5] Swapless V2: Revise main migration logic Message-Id: <20060414101959.d59ac82d.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20060413235432.15398.23912.sendpatchset@schroedinger.engr.sgi.com> References: <20060413235406.15398.42233.sendpatchset@schroedinger.engr.sgi.com> <20060413235432.15398.23912.sendpatchset@schroedinger.engr.sgi.com> Organization: Fujitsu X-Mailer: Sylpheed version 2.2.0 (GTK+ 2.6.10; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Apr 2006 16:54:32 -0700 (PDT) Christoph Lameter wrote: > > + inc_mm_counter(mm, anon_rss); > + get_page(new); > + set_pte_at(mm, addr, ptep, pte_mkold(mk_pte(new, vma->vm_page_prot))); > + page_add_anon_rmap(new, vma, addr); Just a note: This will cause unecessary copy-on-write later. (current remove_from_swap() can cause copy-on-write....) But maybe copy-on-write is just minor case for migrating specified vmas. For hotremove (I stops it now..), we should fix this later (if we can do). If new SWP_TYPE_MIGRATION swp entry can contain write protect bit, hotremove can avoid copy-on-write but things will be more complicated. -Kame