From: Andrew Morton <akpm@osdl.org>
To: Vadim Lobanov <vlobanov@speakeasy.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Poll microoptimizations.
Date: Fri, 14 Apr 2006 14:38:20 -0700 [thread overview]
Message-ID: <20060414143820.6a04b696.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0604141413260.21335@shell2.speakeasy.net>
Vadim Lobanov <vlobanov@speakeasy.net> wrote:
>
> I can put in a comment to explain what the code is doing, or if you
> think that the bitmasking itself is "yuk", then I can easily transform
> the code into an explicit "if () {}" block. :)
yes please.
> > Yuk. Sorry, no.
>
> Thank you for the review. The comments above are easy to address. Do you
> like the main concept behind the patch? Should I correct and resubmit?
I don't really understand it yet.
Yes, please resend and feel free to a) add comments in places where we can
help people to understand the code and b) convert any code which gets
touched to be coding-style-friendly. (I usually recommend that we do that
even if the surrounding code uses different conventions - eventually
everything will be fixed ;))
next prev parent reply other threads:[~2006-04-14 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 4:21 Vadim Lobanov
2006-04-14 15:51 ` Vadim Lobanov
2006-04-14 19:31 ` Andrew Morton
2006-04-14 21:21 ` Vadim Lobanov
2006-04-14 21:38 ` Andrew Morton [this message]
2006-04-14 21:47 ` Vadim Lobanov
2006-04-15 2:26 ` [PATCH] Poll cleanups/microoptimizations Vadim Lobanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060414143820.6a04b696.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®