From: Robin Holt <holt@sgi.com>
To: Keith Owens <kaos@sgi.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Dean Nelson <dcn@americas.sgi.com>
Subject: Re: Is notify_die being overloaded?
Date: Sat, 15 Apr 2006 05:43:56 -0500 [thread overview]
Message-ID: <20060415104355.GA7156@lnx-holt.americas.sgi.com> (raw)
In-Reply-To: <22910.1145081995@ocs3.ocs.com.au>
On Sat, Apr 15, 2006 at 04:19:55PM +1000, Keith Owens wrote:
> Robin Holt (on Thu, 13 Apr 2006 14:46:44 -0500) wrote:
> >notify_die seems to be called to indicate the machine is going down as
> >well as there are trapped events for the process.
...
> The only real problem is the page fault handler event. All the other
...
>
> kprobes should be using its own notify chain to trap page faults, and
> the handler for that chain should be optimized away when
> CONFIG_KPROBES=n or there are no active probes.
I realize the page fault handler is the only performance critical event,
but don't all the debugging events _REALLY_ deserve a seperate call chain?
They are _completely_ seperate and isolated events. One is a minor event
which a small number of other userland processes are concerned with.
The other is indicating the machine is about stop running and is only
relevant to critical system infrastructure.
When I get back from vacation on Tuesday, I will try to work up a patch
which introduces a notify_debug() call and its call chain. Maybe that
will initiate more discussion.
Thanks,
Robin
next prev parent reply other threads:[~2006-04-15 10:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 19:46 Robin Holt
2006-04-15 6:19 ` Keith Owens
2006-04-15 10:43 ` Robin Holt [this message]
2006-04-17 7:52 ` Keith Owens
2006-04-17 10:51 ` Robin Holt
2006-04-17 11:25 ` Robin Holt
2006-04-18 0:23 ` Keith Owens
2006-04-18 22:16 ` ia64_do_page_fault shows 19.4% slowdown from notify_die Robin Holt
2006-04-18 23:03 ` Keshavamurthy Anil S
2006-04-19 0:30 ` Andi Kleen
2006-04-19 11:11 ` Robin Holt
2006-04-17 16:50 ` Is notify_die being overloaded? Keshavamurthy Anil S
2006-04-17 16:45 ` Keshavamurthy Anil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060415104355.GA7156@lnx-holt.americas.sgi.com \
--to=holt@sgi.com \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=dcn@americas.sgi.com \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®