mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
	Mark Fasheh <mark.fasheh@oracle.com>,
	Kurt Hackel <kurt.hackel@oracle.com>,
	ocfs2-devel@oss.oracle.com,
	Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH 1/5] Remove redundant NULL checks before [kv]free - in fs/
Date: Mon, 17 Apr 2006 03:29:11 +0200	[thread overview]
Message-ID: <200604170329.11589.jesper.juhl@gmail.com> (raw)

Remove redundant NULL checks before kfree
for fs/

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 fs/ocfs2/vote.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff -upr linux-2.6.17-rc1-git12-orig/fs/ocfs2/vote.c linux-2.6.17-rc1-git12/fs/ocfs2/vote.c
--- linux-2.6.17-rc1-git12-orig/fs/ocfs2/vote.c	2006-04-09 13:58:32.000000000 +0200
+++ linux-2.6.17-rc1-git12/fs/ocfs2/vote.c	2006-04-16 15:03:05.000000000 +0200
@@ -988,9 +988,7 @@ int ocfs2_request_mount_vote(struct ocfs
 	}
 
 bail:
-	if (request)
-		kfree(request);
-
+	kfree(request);
 	return status;
 }
 
@@ -1021,9 +1019,7 @@ int ocfs2_request_umount_vote(struct ocf
 	}
 
 bail:
-	if (request)
-		kfree(request);
-
+	kfree(request);
 	return status;
 }
 

             reply	other threads:[~2006-04-17  1:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-17  1:29 Jesper Juhl [this message]
2006-04-19  4:42 ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604170329.11589.jesper.juhl@gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome