From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH][urgent fix] swsusp: prevent possible image corruption on resume
Date: Mon, 17 Apr 2006 15:03:07 +0200 [thread overview]
Message-ID: <20060417130307.GC1886@elf.ucw.cz> (raw)
In-Reply-To: <200604171449.24548.rjw@sisk.pl>
Hi!
> The function free_pagedir() used by swsusp for freeing its internal data
> structures clears the PG_nosave and PG_nosave_free flags for each page being
> freed. However, during resume PG_nosave_free set means that the page
> in question is "unsafe" (ie. it will be overwritten in the process of restoring the
> saved system state from the image), so it should not be used for the image
> data. Therefore free_pagedir() should not clear PG_nosave_free if it's
> called during resume (otherwise "unsafe" pages freed by it may be used for
> storing the image data and the data may get corrupted later on).
Okay with me.
Pavel
--
Thanks for all the (sleeping) penguins.
prev parent reply other threads:[~2006-04-17 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-17 12:49 Rafael J. Wysocki
2006-04-17 13:03 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060417130307.GC1886@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®