From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbWDQWFW (ORCPT ); Mon, 17 Apr 2006 18:05:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751338AbWDQWFW (ORCPT ); Mon, 17 Apr 2006 18:05:22 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:37762 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751337AbWDQWFV (ORCPT ); Mon, 17 Apr 2006 18:05:21 -0400 Date: Mon, 17 Apr 2006 23:05:12 +0100 From: Christoph Hellwig To: Lee Revell Cc: Adrian McMenamin , Paul Mundt , Alsa-devel , linux-sh , LKML Subject: Re: [Alsa-devel] Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast Message-ID: <20060417220512.GA16119@infradead.org> Mail-Followup-To: Christoph Hellwig , Lee Revell , Adrian McMenamin , Paul Mundt , Alsa-devel , linux-sh , LKML References: <1145232784.12804.2.camel@localhost.localdomain> <20060417012913.GA16821@linux-sh.org> <1145304037.9244.27.camel@localhost.localdomain> <1145310435.16138.83.camel@mindpipe> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1145310435.16138.83.camel@mindpipe> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2006 at 05:47:15PM -0400, Lee Revell wrote: > On Mon, 2006-04-17 at 21:00 +0100, Adrian McMenamin wrote: > > But I am happy to change it. > > > > > > Please don't - when adding code to a subsystem with different > conventions than mainline the FAQ says to follow the subsystem > conventions. Nope. Alsa needs to gradually converted from something that looks like cat puke to normal kernel style. Every new driver that's written properly helps.