From: Henrik Brix Andersen <brix@gentoo.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: PATCH [2/3]: Provide generic backlight support in IBM ACPI driver
Date: Tue, 18 Apr 2006 11:18:57 +0200 [thread overview]
Message-ID: <20060418091857.GB30628@osgiliath> (raw)
In-Reply-To: <20060418083056.GA13846@srcf.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Tue, Apr 18, 2006 at 09:30:56AM +0100, Matthew Garrett wrote:
> diff -urp drivers/acpi.bak/Kconfig drivers/acpi/Kconfig
> --- drivers/acpi.bak/Kconfig 2006-04-18 08:51:49 +0100
> +++ a/drivers/acpi/Kconfig 2006-04-18 09:13:09 +0100
> @@ -195,7 +195,7 @@ config ACPI_ASUS
>
> config ACPI_IBM
> tristate "IBM ThinkPad Laptop Extras"
> - depends on X86
> + depends on X86 && BACKLIGHT_DEVICE
Wouldn't it be better to have ACPI_IBM and friends select
BACKLIGHT_DEVICE?
Regards,
Brix
--
Henrik Brix Andersen <brix@gentoo.org>
Gentoo Metadistribution | Mobile computing herd
[-- Attachment #2: Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2006-04-18 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 8:29 PATCH [1/3]: Provide generic backlight support in Asus " Matthew Garrett
2006-04-18 8:30 ` PATCH [2/3]: Provide generic backlight support in IBM " Matthew Garrett
2006-04-18 8:32 ` PATCH [3/3]: Provide generic backlight support in Toshiba " Matthew Garrett
2006-04-18 9:18 ` Henrik Brix Andersen [this message]
2006-04-18 9:26 ` PATCH [2/3]: Provide generic backlight support in IBM " Matthew Garrett
2006-04-18 16:11 ` PATCH [1/3]: Provide generic backlight support in Asus " Patrick Mochel
2006-04-18 16:28 ` Matthew Garrett
2006-04-19 18:49 ` Matthew Garrett
2006-04-19 18:49 ` PATCH [2/3]: Provide generic backlight support in IBM " Matthew Garrett
2006-04-19 18:50 ` PATCH [3/3]: Provide generic backlight support in Toshiba " Matthew Garrett
2006-04-19 18:53 ` PATCH [1/3]: Provide generic backlight support in Asus " Patrick Mochel
2006-04-19 20:13 ` Henrik Brix Andersen
2006-04-19 20:25 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418091857.GB30628@osgiliath \
--to=brix@gentoo.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®