mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Nigel Cunningham <ncunningham@cyclades.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET
Date: Tue, 18 Apr 2006 16:16:14 -0700	[thread overview]
Message-ID: <20060418161614.321b61e7.akpm@osdl.org> (raw)
In-Reply-To: <200604190844.25476.ncunningham@cyclades.com>

Nigel Cunningham <ncunningham@cyclades.com> wrote:
>
> --- 9904.patch-old/kernel/sysctl.c	2006-04-19 08:40:47.000000000 +1000
> +++ 9904.patch-new/kernel/sysctl.c	2006-04-17 21:06:23.000000000 +1000
> @@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
>  		.strategy	= &sysctl_string,
>  	},
>  #endif
> -#ifdef CONFIG_HOTPLUG
> +#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)

I've had this in -mm for a couple of weeks now but rmk points out that it's
rather silly.  Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the
kernel cannot deliver hotplug events to userspace..

So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better,
CONFIG_NETLINK.

Dunno.  I left this in Greg's lap, but he's hiding.

  reply	other threads:[~2006-04-18 23:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-18 22:44 Nigel Cunningham
2006-04-18 23:16 ` Andrew Morton [this message]
2006-04-18 23:17   ` Nigel Cunningham
2006-04-19  0:25   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060418161614.321b61e7.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome