From: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-acpi@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH] -mm: make pmtmr_ioport __read_mostly
Date: Tue, 18 Apr 2006 20:44:13 +0200 [thread overview]
Message-ID: <20060418184413.GA23331@rhlx01.fht-esslingen.de> (raw)
Hello all,
- written on init only, accessed for every timer read --> __read_mostly
- fix broken sentence
Patch tested on 2.6.17-rc1-mm2, rediffed against 2.6.17-rc1-mm3.
I did not test the x86_64 part, though, for obvious reasons.
Signed-off-by: Andreas Mohr <andi@lisas.de>
diff -urN linux-2.6.17-rc1-mm3.orig/drivers/clocksource/acpi_pm.c linux-2.6.17-rc1-mm3/drivers/clocksource/acpi_pm.c
--- linux-2.6.17-rc1-mm3.orig/drivers/clocksource/acpi_pm.c 2006-04-18 20:06:57.000000000 +0200
+++ linux-2.6.17-rc1-mm3/drivers/clocksource/acpi_pm.c 2006-04-18 20:08:19.000000000 +0200
@@ -30,7 +30,7 @@
* The location is detected during setup_arch(),
* in arch/i386/acpi/boot.c
*/
-u32 pmtmr_ioport;
+u32 pmtmr_ioport __read_mostly;
#define ACPI_PM_MASK 0xFFFFFF /* limit it to 24 bits */
@@ -47,7 +47,7 @@
/*
* It has been reported that because of various broken
* chipsets (ICH4, PIIX4 and PIIX4E) where the ACPI PM clock
- * source is not latched, so you must read it multiple
+ * source is not latched, you must read it multiple
* times to ensure a safe value is read:
*/
do {
diff -urN linux-2.6.17-rc1-mm3.orig/arch/x86_64/kernel/pmtimer.c linux-2.6.17-rc1-mm3/arch/x86_64/kernel/pmtimer.c
--- linux-2.6.17-rc1-mm3.orig/arch/x86_64/kernel/pmtimer.c 2006-04-03 05:22:10.000000000 +0200
+++ linux-2.6.17-rc1-mm3/arch/x86_64/kernel/pmtimer.c 2006-04-18 20:36:35.000000000 +0200
@@ -27,7 +27,7 @@
/* The I/O port the PMTMR resides at.
* The location is detected during setup_arch(),
* in arch/i386/kernel/acpi/boot.c */
-u32 pmtmr_ioport;
+u32 pmtmr_ioport __read_mostly;
/* value of the Power timer at last timer interrupt */
static u32 offset_delay;
reply other threads:[~2006-04-18 18:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418184413.GA23331@rhlx01.fht-esslingen.de \
--to=andi@rhlx01.fht-esslingen.de \
--cc=akpm@osdl.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®