From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750741AbWDTHMI (ORCPT ); Thu, 20 Apr 2006 03:12:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750744AbWDTHMI (ORCPT ); Thu, 20 Apr 2006 03:12:08 -0400 Received: from smtp.osdl.org ([65.172.181.4]:55766 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750741AbWDTHMG (ORCPT ); Thu, 20 Apr 2006 03:12:06 -0400 Date: Thu, 20 Apr 2006 00:11:06 -0700 From: Andrew Morton To: Tilman Schmidt Cc: kkeil@suse.de, isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org, hjlipp@web.de Subject: Re: [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling Message-Id: <20060420001106.23d08ca7.akpm@osdl.org> In-Reply-To: <200604191838.k3JIc1eX022982@lx1.pxnet.com> References: <200604191838.k3JIc1eX022982@lx1.pxnet.com> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Tilman Schmidt wrote: > > This patch fixes a possible Oops in the Siemens Gigaset base driver when > the device is unplugged while an ISDN connection is still active, and > makes sure that the isdn4linux link level (LL) is properly informed if a > connection is broken by the USB cable being unplugged. > It also improves some kernel messages generated by the driver. It seems to do quite a lot more than that. > Please merge at your earliest convenience. Well OK, but I'd ask you to confirm that this was actually the patch which was supposed to go with that changelog. > --- linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c 2006-04-19 15:15:49.000000000 +0200 > +++ local/drivers/isdn/gigaset/bas-gigaset.c 2006-04-19 01:19:41.000000000 +0200 eek, please don't do that - it confuses my scripts. --- linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c +++ linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c is preferred. There are nice tools around which help with this.