From: Andrew Morton <akpm@osdl.org>
To: Christian Praehauser <cpraehaus@cosy.sbg.ac.at>
Cc: linux-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dvb-core: ULE fixes and RFC4326 additions (kernel 2.6.16)
Date: Thu, 20 Apr 2006 01:18:26 -0700 [thread overview]
Message-ID: <20060420011826.453937b1.akpm@osdl.org> (raw)
In-Reply-To: <44474282.8050604@cosy.sbg.ac.at>
Christian Praehauser <cpraehaus@cosy.sbg.ac.at> wrote:
>
> + static const u8 bc_addr[ETH_ALEN] = {0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF};
There's a nicer way:
--- devel/drivers/media/dvb/dvb-core/dvb_net.c~dvb-core-ule-fixes-and-rfc4326-additions-kernel-2616-fix 2006-04-20 01:16:26.000000000 -0700
+++ devel-akpm/drivers/media/dvb/dvb-core/dvb_net.c 2006-04-20 01:17:29.000000000 -0700
@@ -639,7 +639,8 @@ static void dvb_net_ule( struct net_devi
} else {
/* CRC32 verified OK. */
u8 dest_addr[ETH_ALEN];
- static const u8 bc_addr[ETH_ALEN] = {0xFF,};
+ static const u8 bc_addr[ETH_ALEN] =
+ { [ 0 ... ETH_ALEN-1] = 0xff };
/* CRC32 was OK. Remove it from skb. */
priv->ule_skb->tail -= 4;
_
next prev parent reply other threads:[~2006-04-20 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 15:06 Christian Praehauser
2006-04-20 6:53 ` Andrew Morton
2006-04-20 8:12 ` Christian Praehauser
2006-04-20 8:18 ` Andrew Morton [this message]
2006-04-20 10:09 ` Christian Praehauser
2006-04-20 10:26 ` Andrew Morton
2006-04-20 11:48 ` Christian Praehauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060420011826.453937b1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=cpraehaus@cosy.sbg.ac.at \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®