From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbWDUHns (ORCPT ); Fri, 21 Apr 2006 03:43:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751303AbWDUHns (ORCPT ); Fri, 21 Apr 2006 03:43:48 -0400 Received: from cantor.suse.de ([195.135.220.2]:2250 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751298AbWDUHnq (ORCPT ); Fri, 21 Apr 2006 03:43:46 -0400 Date: Fri, 21 Apr 2006 09:43:45 +0200 From: Nick Piggin To: Nick Piggin Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch 1/5] mm: remap_vmalloc_range Message-ID: <20060421074345.GN21660@wotan.suse.de> References: <20060301045901.12434.54077.sendpatchset@linux.site> <20060301045910.12434.4844.sendpatchset@linux.site> <20060421002938.3878aec5.akpm@osdl.org> <20060421074156.GM21660@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060421074156.GM21660@wotan.suse.de> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2006 at 09:41:57AM +0200, Nick Piggin wrote: > On Fri, Apr 21, 2006 at 12:29:38AM -0700, Andrew Morton wrote: > > > > When replacing calls to remap_pfn_rage() with calls to remap_valloc_range(): > > > > - remap_pfn_range() sets VM_IO|VM_RESERVED|VM_PFNMAP on the user's vma. > > remap_valloc_range() sets only VM_RESERVED. > > Yep, it doesn't use PFNMAPs (we can always user the underlying struct > page), nor is it IO space. The only change that should be seen, as > noted in patch 4/5, is that get_user_pages will work on all mappings > now. I don't think there is a downside to this? By "change that should be seen", I mean the only change that userspace should see.