mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Mathieu Chouquet-Stringer <mchouque@free.fr>,
	Bob Tracy <rct@gherkin.frus.com>,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	rth@twiddle.net
Subject: Re: strncpy (maybe others) broken on Alpha
Date: Fri, 21 Apr 2006 18:22:23 +0400	[thread overview]
Message-ID: <20060421182223.C19738@jurassic.park.msu.ru> (raw)
In-Reply-To: <20060421115556.GA14178@bigip.bigip.mine.nu>; from mchouque@free.fr on Fri, Apr 21, 2006 at 01:55:56PM +0200

On Fri, Apr 21, 2006 at 01:55:56PM +0200, Mathieu Chouquet-Stringer wrote:
> I've attached to this email a tarball of what I use to test the
> compiler/binutils.  It's faster than recompiling the whole kernel on
> these slow machines!

Oops. I was using a wrong copy of strncpy.S (remained from previous
__stxncpy() debugging). What's why I wasn't able to reproduce that...

It seems that the registers $24 and $27 are mixed up in strncpy().
This fixes your test case, please check if it fixes kernel problem
as well.

Ivan.

--- strncpy_debug/strncpy.S	Thu Apr 20 14:18:05 2006
+++ strncpy.S	Fri Apr 21 17:52:04 2006
@@ -43,8 +43,8 @@
 
 	.align	4
 $multiword:
-	subq	$24, 1, $2	# clear the final bits in the prev word
-	or	$2, $24, $2
+	subq	$27, 1, $2	# clear the final bits in the prev word
+	or	$2, $27, $2
 	zapnot	$1, $2, $1
 	subq	$18, 1, $18
 
@@ -70,8 +70,8 @@
 	bne	$18, 0b
 
 1:	ldq_u	$1, 0($16)	# clear the leading bits in the final word
-	subq	$27, 1, $2
-	or	$2, $27, $2
+	subq	$24, 1, $2
+	or	$2, $24, $2
 
 	zap	$1, $2, $1
 	stq_u	$1, 0($16)

  reply	other threads:[~2006-04-21 14:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-19 21:31 class_device_add error in SCSI with 2.6.17-rc2-g52824b6b Mathieu Chouquet-Stringer
2006-04-19 21:58 ` Bob Tracy
2006-04-19 22:17   ` Mathieu Chouquet-Stringer
2006-04-20 10:14   ` Mathieu Chouquet-Stringer
2006-04-20 10:57     ` Mathieu Chouquet-Stringer
2006-04-20 17:11     ` strncpy (maybe others) broken on Alpha Mathieu Chouquet-Stringer
2006-04-20 20:55       ` Mathieu Chouquet-Stringer
2006-04-20 21:24         ` Ivan Kokshaysky
2006-04-20 21:27           ` Mathieu Chouquet-Stringer
2006-04-20 21:40           ` Bob Tracy
2006-04-20 21:57           ` Mathieu Chouquet-Stringer
2006-04-21  2:43             ` Bob Tracy
2006-04-21  8:15               ` Mathieu Chouquet-Stringer
2006-04-21  9:21                 ` Mathieu Chouquet-Stringer
2006-04-21  9:50                   ` Mathieu Chouquet-Stringer
2006-04-21 11:41                     ` Bob Tracy
2006-04-21 11:55                       ` Mathieu Chouquet-Stringer
2006-04-21 14:22                         ` Ivan Kokshaysky [this message]
2006-04-21 19:37                           ` Bob Tracy
2006-04-21 21:12                             ` Ivan Kokshaysky
2006-04-21 22:49                               ` Bob Tracy
2006-04-22  8:47                                 ` Mathieu Chouquet-Stringer
2006-04-22  8:45                           ` Mathieu Chouquet-Stringer
2006-04-22 10:39                     ` Bryan Østergaard
2006-04-20 21:22       ` Ivan Kokshaysky
2006-04-20 21:25         ` Mathieu Chouquet-Stringer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060421182223.C19738@jurassic.park.msu.ru \
    --to=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchouque@free.fr \
    --cc=rct@gherkin.frus.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®