From: Pavel Machek <pavel@suse.cz>
To: Hugh Dickins <hugh@veritas.com>
Cc: Arkadiusz Miskiewicz <arekm@maven.pl>,
Jeff Chua <jeffchua@silk.corp.fedex.com>,
Jeff Garzik <jeff@garzik.org>, Matt Mackall <mpm@selenic.com>,
Jens Axboe <axboe@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: sata suspend resume ...
Date: Fri, 21 Apr 2006 23:15:55 +0200 [thread overview]
Message-ID: <20060421211555.GB3206@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0604212108010.7531@blonde.wat.veritas.com>
Hi!
> This is a patch I'd not be ashamed to send Jeff Garzik cc linux-ide,
> even if we can't name precisely why it's ATA_BUSY then. But I'll
> give it a day or so of real-life suspend/resuming first - Arkadiusz
> and I both noticed we're more likely to resume successfully after
> a brief suspend, so longer suspends are needed for proper testing.
Thanks, looks good.
Pavel
> Hugh
>
> --- 2.6.17-rc2/drivers/scsi/libata-core.c 2006-04-19 09:14:11.000000000 +0100
> +++ linux/drivers/scsi/libata-core.c 2006-04-21 20:55:48.000000000 +0100
> @@ -4288,6 +4288,7 @@ int ata_device_resume(struct ata_port *a
> {
> if (ap->flags & ATA_FLAG_SUSPENDED) {
> ap->flags &= ~ATA_FLAG_SUSPENDED;
> + ata_busy_sleep(ap, ATA_TMOUT_BOOT_QUICK, ATA_TMOUT_BOOT);
> ata_set_mode(ap);
> }
> if (!ata_dev_present(dev))
--
Thanks for all the (sleeping) penguins.
next prev parent reply other threads:[~2006-04-21 21:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 15:26 Jeff Chua
2006-04-19 15:52 ` Arkadiusz Miskiewicz
2006-04-20 2:18 ` Jeff Chua
2006-04-19 16:13 ` Hugh Dickins
2006-04-19 16:56 ` Arkadiusz Miskiewicz
2006-04-19 17:08 ` Hugh Dickins
2006-04-19 21:49 ` Matt Mackall
2006-04-19 22:50 ` Hugh Dickins
2006-04-19 22:57 ` Matt Mackall
2006-04-19 23:26 ` Hugh Dickins
2006-04-20 13:25 ` Arkadiusz Miskiewicz
2006-04-20 13:47 ` Pavel Machek
2006-04-21 12:49 ` Hugh Dickins
2006-04-21 16:39 ` Pavel Machek
2006-04-21 20:44 ` Hugh Dickins
2006-04-21 20:50 ` Matt Mackall
2006-04-21 21:15 ` Pavel Machek [this message]
2006-04-21 21:36 ` Jeff Garzik
2006-04-23 12:58 ` Hugh Dickins
2006-04-29 18:06 ` Hugh Dickins
2006-04-21 23:39 ` Chris Ball
2006-04-23 12:42 ` Hugh Dickins
2006-04-23 13:52 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060421211555.GB3206@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=arekm@maven.pl \
--cc=axboe@suse.de \
--cc=hugh@veritas.com \
--cc=jeff@garzik.org \
--cc=jeffchua@silk.corp.fedex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®